Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup github actions for testing #4

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

MattsonCam
Copy link
Member

@MattsonCam MattsonCam commented Nov 19, 2024

This is the basic setup of github actions to run pytest whenever merging, or on a pull_request with main as the target branch. This is intended to test the code to ensure proper functioning of the pairwise_compare tool. I still need to commit additional changes, so I expect failures until then. I wanted to include this github actions functionality before I commit these changes to the currently open pr on the development branch. Please let me know if you have any constructive feedback.

This is the basic setup of github actions to run pytest whenever merging, or on pull_request.
@MattsonCam MattsonCam requested a review from d33bs November 19, 2024 20:58
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! This looks like a useful change. I made a few comments up for your consideration, let me know if you have any questions about anything.

I noticed the tests fail currently because there's no pyproject.toml file to reference yet. You might consider pulling these changes into #1 after a merge to main, or possibly making the merge target of this PR the branch which #1 is based on (not sure if that's possible, but could be worth a try).

Would the work here pertain to #3 ? If so, consider updating the description of the PR to include something like closes #3 to help automatically close the issue when the PR is merged (only if you feel it should be closed after merge, otherwise you could reference #3, etc.).

.github/workflows/python-app.yml Outdated Show resolved Hide resolved
.github/workflows/python-app.yml Outdated Show resolved Hide resolved
.github/workflows/python-app.yml Outdated Show resolved Hide resolved
.github/workflows/python-app.yml Outdated Show resolved Hide resolved
.github/workflows/python-app.yml Outdated Show resolved Hide resolved
.github/workflows/python-app.yml Outdated Show resolved Hide resolved
.github/workflows/python-app.yml Show resolved Hide resolved
@MattsonCam
Copy link
Member Author

Thanks @d33bs, merging now!

@MattsonCam MattsonCam merged commit 80e3e15 into main Nov 20, 2024
0 of 2 checks passed
@MattsonCam MattsonCam deleted the github_actions_testing branch November 20, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants