Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support React exercise picker #3

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Conversation

Wassup789
Copy link
Owner

Description

An update specifically with the workouts editor in Garmin Connect caused the exercise selector enhancement to break. Garmin switched to using React for their exercise picker which required a refactor of the previously implemented exercise selector to allow expansion for multiple implementations of exercise pickers.

PR Type

  • Bug fix
  • Feature
  • Code-style update
  • Refactoring
  • Documentation update
  • Build related changes
  • CI / CD related changes
  • Other, describe here:

Tests performed

Manual

Additional information

This PR will resolve #2.

@Wassup789 Wassup789 added the bug Something isn't working label Aug 3, 2024
@Wassup789 Wassup789 self-assigned this Aug 3, 2024
@Wassup789 Wassup789 marked this pull request as ready for review August 4, 2024 18:56
@Wassup789 Wassup789 merged commit d47bd1a into main Aug 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancements features doesn't appear on Garmin
1 participant