Do not remove vision from transporters when loading saves #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents transporters sitting in the dark if they are positioned somewhere away from other vision granting objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No point in removing vision from the transporter itself, as the intent was to do this for droids inside one. Very easy to see this bug by using debug mode to send a transporter to an unexplored area on a skirmish map. And yes, this happens in campaign too albeit not so noticeable.
There is still another vision issue related to transporters not fixed by this PR: when a transporter is away on an offworld mission, the spot where it left the map will be lit up after saveload for a brief moment. Acting as if it were centered around that spot.