-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Brief and Proximity files to JSON #4068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To eventually replace the CSV files with JSON variants that are much easier to understand.
Just turns it into a placeholder for the WIN and END messages.
Not used, just removing any remnants of SMSG.
Moved a message in cam1messages to brief1a. The other files had unused IDs or repeated inclusions for END. camX.wrf files now point to the previously unused genmessages file which will hold WIN/END to reduce duplication.
Add genmessages to the fastplay WRF file.
Weird situation where 1 video in both brief3intro and brief3-a got used. We can use 1 file instead.
Original game wrong messages, wrong sound file, missing sound file, and bad locations.
Remove outro video since that gets played in the source.
KJeff01
force-pushed
the
smsg
branch
2 times, most recently
from
October 16, 2024 20:32
9ff584c
to
0b65723
Compare
Not used and will require additional video playback tweaks to support it properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giga PR to mass convert each campaign Brief and Proximity file to something a lot more readable and mod friendly.
First phase was to convert each Brief/Prox file 1:1 (aside from 1 exception where beta 1 had a disabled video which I ignored), and to introduce a document on the new format. The last of my commits deal with cleaning up unnecessary briefing files that mostly were related to having the END (mission failed) video present. Here, I just put END/WIN in genmessages and included that file into the appropriate WRF files. Finally, upon converting the Prox files I noticed several issues with incorrect/missing sound files when clicking on a proximity blip among other things which I fixed.
The C++ functions may need some additional error checking or cleanup, and maybe some fixes to the document as well. Otherwise it all appears to be working just fine bar any errors in the conversions. Presumably we could rip out
SMSG
entirely in the not too distant future.Reviewing this PR will take a bit of extra effort since you'll need to understand the CSV format. I have a guide below: