research.json: Add support for new "calculationMode" option, "Improved" calculation mode #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
past-due
force-pushed
the
2024_04_research_upgrade_calculations_1
branch
from
18fa68c to
79dc8b4
Compare
The default `"calculationMode"` is `"compat"`, and functions as many previous versions for many years have. This mode can accumulate noticeable error - especially if repeatedly upgrading small values by smaller percentages (commonly impacted: armour, thermal).
The new opt-in `"calculationMode"` is `"improved"`. This handles calculating upgrades in a way that significantly reduces accumulated errors from multiple applied research upgrades to a component's value(s).
To opt-in to the new mode, add a new "_config_" dict to the top-level research.json object, specifying the desired "calculationMode".
Example:
```json
{
"_config_": {
"calculationMode": "improved"
},
...
}
```
past-due
force-pushed
the
2024_04_research_upgrade_calculations_1
branch
from
79dc8b4 to
32d8fcf
Compare
ManManson
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
"calculationMode"is"compat", and functions as many previous versions for many years have. This mode can accumulate noticeable error - especially if repeatedly upgrading small values by smaller percentages (commonly impacted: armour, thermal).The new opt-in
"calculationMode"is"improved". This handles calculating upgrades in a way that significantly reduces accumulated errors from multiple applied research upgrades to a component's value(s).To opt-in to the new mode, add a new "config" dict to the top-level research.json object, specifying the desired "calculationMode".
Example:
{ "_config_": { "calculationMode": "improved" }, ... }