New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

research.cpp: When upgrade change value is negative, use iDivFloor #3795

Merged

past-due merged 1 commit into Warzone2100:master from past-due:2024_04_upgrades_valuereduction_rounding_1

May 7, 2024

Member

past-due commented May 7, 2024

This resolves an issue where upgrades that used negative values in results ¹ could have an unanticipated (and undesired) error.

Example: https://github.com/Warzone2100/warzone2100/blob/e025ff02eb8fb95cdd1120d7a87555f2a8d93c3a/data/mods/campaign/wz2100_camclassic/stats/research.json#L10-L25 ↩


          research.cpp: When upgrade change value is negative, use iDivFloor

3ec9bdd

ManManson approved these changes

View reviewed changes

past-due merged commit 2f00d6d into Warzone2100:master

37 checks passed

past-due deleted the 2024_04_upgrades_valuereduction_rounding_1 branch

May 7, 2024 13:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet