netplay.cpp: separate global socket_set into client_socket_set and server_socket_set
#3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d `server_socket_set` Not only this makes it easier to decompose the code better and decouple things, but also it's much easier to read and understand the code, e.g. which functions operate in which context. Ideally, we would like to completely separate client-side-only and server-side-only code at some point, which would greatly increase maintainability. Tests: local LAN hosting + joining, leaving MP games. Signed-off-by: Pavel Solodovnikov <[email protected]>
past-due
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only this makes it easier to decompose the code better and decouple things, but also it's much easier to read and understand the code, e.g. which functions operate in which context.
Ideally, we would like to completely separate client-side-only and server-side-only code at some point, which would greatly increase maintainability.
Tests: local LAN hosting + joining, leaving MP games.