Add "FORTRESS" structure type (with fixes), and fix "GENERIC" structure type #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
past-due
force-pushed
the
2024_04_structure_types_generic_fortress_1
branch
from
42071cd to
0003470
Compare
Sure seems like fortresses should be considered a threat.
past-due
force-pushed
the
2024_04_structure_types_generic_fortress_1
branch
2 times, most recently
from
9fbc369 to
eefdbae
Compare
Instead, support targeting GENERIC separately with: "filterParameter": "Type", "filterValue": "Generic"
past-due
force-pushed
the
2024_04_structure_types_generic_fortress_1
branch
from
eefdbae to
bdeee12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #3775
Fixes: #3773
The only 4 structures that were previously using "GENERIC" were the fortresses. Presumably this was to opt them out of certain behavior that "DEFENSE" structures get (such as allowing building on any slope, and struct packing, and foundation stretching), but it also had the side effect of not giving them the same
targetAttackWeightbonus as other defensive structs and not treating them as threats inThreatInRange.So, instead of adding a new type for "generic" structures, this PR:
STRUCT_GENERICJS constant, and exposes this in the JS structure objectstattypeproperty for "GENERIC" structures (of which there are now none in the built-in stats files)Potentially breaking change:
structure.jsonshould probably update"type": "GENERIC"->"type": "FORTRESS"for any true fortress structures (unless they want the fixed GENERIC struct behavior).