Check psTile->psObject before resetting #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManManson
approved these changes
Apr 28, 2024
With the recent changes that may cause script object removals to be queued (and permit building structures on top of structures queued for removal), ensure that `psTile->psObject` is only reset if it matches the object being deleted.
past-due
force-pushed
the
2024_04_check_tile_object_before_resetting_1
branch
from
fdb7e04 to
4abd1c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes that may cause script object removals to be queued (and permit building structures on top of structures queued for removal, see: #3767), ensure that
psTile->psObjectis only reset if it matches the object being deleted.