Switch PROJECTILE to use PagedEntityContainer<PROJECTILE> as backing storage
#3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better to avoid self-destructing methods that do `delete this` or similar. Signed-off-by: Pavel Solodovnikov <[email protected]>
The method translates the address of the argument to container's page index for the corresponding element. Add a couple of asserts in `erase()` Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
projectile_refactor_v2
branch
from
dbc938d to
fb9bc37
Compare
past-due
reviewed
Mar 10, 2024
ManManson
force-pushed
the
projectile_refactor_v2
branch
from
fb9bc37 to
0e9b459
Compare
…ing storage The game still uses `psProjectileList` to maintain stable and predictable order of iteration for projectiles, but the individual `PROJECTILE` instances are allocated from the global `PagedEntityContainer<PROJECTILE>` instance. Optimize `proj_UpdateAll()` by removing additional checks inside the tight loop, which enumerates all projectiles currently in play, thus considerably speeding up this frequent and expensive operation. Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
projectile_refactor_v2
branch
from
0e9b459 to
7dc704c
Compare
KJeff01
approved these changes
Mar 13, 2024
past-due
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The game still uses
psProjectileListto maintain stable and predictable order of iteration for projectiles, but the individualPROJECTILEinstances are allocated from the globalPagedEntityContainer<PROJECTILE>instance.Optimize
proj_UpdateAll()by removing additional checks inside the tight loop, which enumerates all projectiles currently in play, thus considerably speeding up this frequent and expensive operation.Brief summary for the performance impact of this PR: on my machine this PR yields ~5-10 FPS improvement in stress-test conditions (e.g. horde of units with Seraph weapons, simultaneously firing lots of projectiles in one direction).
Signed-off-by: Pavel Solodovnikov [email protected]