Provide optimized page-based storage and use it for EFFECT:s
#3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
past-due
force-pushed
the
paged_entity_container
branch
from
e1905de to
93db3e8
Compare
This decreases the overall `sizeof(EFFECT)` from 96 to 88 when tested on Windows x86_64 build. Signed-off-by: Pavel Solodovnikov <[email protected]>
…-game entities `PagedEntityContainer` is an optimized page-based container for various in-game entities, capable of recycling erased elements, which greatly reduces memory fragmentation for rapidallocation/deallocation patterns. Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
past-due
force-pushed
the
paged_entity_container
branch
from
93db3e8 to
1f5cfee
Compare
past-due
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patchset contains the following changes:
EFFECTclass, which saves 8 bytes for thesizeof(EFFECT)for the x86_64 arch.PagedEntityContaineroptimized container, which is page-based and is capable of reusing storage upon erasing and allocating new elements.PagedEntityContainerto store allEFFECTinstances in the game.The performance impact of this PR is no more than 5-10 FPS difference with current
master, even for extreme stress-testing cases (tested with 20K effects in the existence at the same time), but the memory allocation patterns are much better, because now memory is allocated in large contiguous chunks, and this memory is aggressively reused when old effects disappear and new effects emerge.This should greatly help to prevent crashes related to memory fragmentation.
It is also expected that when
PROJECTILEobjects will use thePagedEntityContaineras the backing storage, the performance differences shall accumulate and become much more visible in conjunction.Signed-off-by: Pavel Solodovnikov [email protected]