Very first steps to make DROID and STRUCTURE look like properly encapsulated C++ classes
#3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
past-due
reviewed
Jan 16, 2024
Replace `droidDamaged()` and `droidCyborg()` free functions by member functions. Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
…mber function Signed-off-by: Pavel Solodovnikov <[email protected]>
… member function Signed-off-by: Pavel Solodovnikov <[email protected]>
…er function Signed-off-by: Pavel Solodovnikov <[email protected]>
…nctions Signed-off-by: Pavel Solodovnikov <[email protected]>
…` member function Signed-off-by: Pavel Solodovnikov <[email protected]>
…print()` member function Signed-off-by: Pavel Solodovnikov <[email protected]>
…CTURE::isFactory()` Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
droid_struct_add_member_functions
branch
from
7c9116d to
c25e85c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset attempts to convert at least some of the free functions for
DROIDandSTRUCTUREmanipulation to be member functions of these classes, so that in some point in future we can build on that and eventually completely encapsulate internal details of those classes and provide a clean API.Not all functions are covered (actually, only a small fraction right now), and the general approach would be to convert only those functions which don't interact with other objects and are isolated to the implementation details of a single instance, not requiring any communication to other modules of the game.