netreplay: Use wzThread* functions instead of std::thread #3544
Conversation
To avoid std::thread::~thread() calling std::terminate() upon non-graceful shutdown.
| @@ -59,14 +59,15 @@ typedef std::vector<uint8_t> SerializedNetMessagesBuffer; | |||
| static moodycamel::BlockingReaderWriterQueue<SerializedNetMessagesBuffer> serializedBufferWriteQueue(256); | |||
| static SerializedNetMessagesBuffer latestWriteBuffer; | |||
| static size_t minBufferSizeToQueue = DefaultReplayBufferSize; | |||
| static std::unique_ptr<wz::thread> saveThread; | |||
| static WZ_THREAD *saveThread = nullptr; | |||
There was a problem hiding this comment.
Is there a reason not to use std::unique_ptr<WZ_THREAD>?
There was a problem hiding this comment.
WZ_THREAD instances should only be created and managed by the wzThread* functions. (They wrap SDL Threads.)
Also, this is one of those things that we actually want to "leak" on a non-graceful shutdown (to avoid various downstream effects that could lead to crash logs that aren't very useful - like in the std::thread destructor case.)
There was a problem hiding this comment.
Then, you still should be able to adopt the raw pointer you get from wzThreadCreate and then just declare a std::unique_ptr with a custom deleter, which will call wzThreadJoin instead of the default delete.
There was a problem hiding this comment.
Looks like my edit stepped on your comment - we actually want this to "leak" on a non-graceful shutdown. (i.e. We don't want to join + wait.)
To avoid
std::thread::~thread()callingstd::terminate()upon non-graceful shutdown.