Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Flag position list-related crash #3539

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

past-due
Copy link
Member

No description provided.

…psFlagPosLists

In certain circumstances, this could cause a flag position to be added to the list more than once, resulting in a double-free later in freeAllFlagPositions().

Using addFlagPositionToList() ensures this does not happen.
@past-due past-due added this to the 4.4.2 milestone Nov 27, 2023
@past-due past-due merged commit 8e550f6 into Warzone2100:master Nov 27, 2023
35 checks passed
@past-due past-due deleted the 2023_11_crash_tweaks_1 branch November 27, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant