-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplayer / network / lobby / chat enhancements #3401
Merged
past-due
merged 61 commits into
Warzone2100:master
from
past-due:2023_09_multi_net_enhancements_1
Oct 11, 2023
Merged
Multiplayer / network / lobby / chat enhancements #3401
past-due
merged 61 commits into
Warzone2100:master
from
past-due:2023_09_multi_net_enhancements_1
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always call gameOverMessage(false) if selectedPlayer is a spectator so that ingame.endTime gets properly set on all clients. (See: 2178c59)
…y has attached child widgets
By force-refreshing the set cursor on mouse enter + window focus gained.
Recalculate layout in more circumstances Add various helper functions
- Ensure focusLost() isn't called when setFocus() is called on the widget that already has focus - Set the new focus widget before calling focusLost() so that any focusLost() handler can obtain the new widget that has focus
Can click the new "+" (Quick Chat) button, or press the "Tab" key, to open Quick Chat.
past-due
force-pushed
the
2023_09_multi_net_enhancements_1
branch
from
October 9, 2023 16:46
fdb7057
to
8f95eba
Compare
If effects of the cheat code modified overlay screens / widgets in certain ways
Instead of before we even get to this shutdown (when loading a save in-game), which could have caused incorrect information to get persisted to profile files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
And a bunch of drive-by fixes:
endconditions.js
: Fix issue leading to possible desync at game endsendLeavingMsg()
: CallNETflush()
(i.e. do a better job of ensuring that this message gets sent before quitting)kf_JumpToResourceExtractor
Using the Keyboard + Quick Chat:
In Lobby:
In-Game:
Once the Quick Chat overlay is open and has focus, key overlays will appear to help navigate the sections:
Future TODOs (in separate PR):