Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop RTR droids from dropping group and accepting orders #2390

Closed

Conversation

stuart
Copy link
Contributor

@stuart stuart commented Nov 11, 2021

This changes the behaviour of retreating droids. They retain their group but will ignore most orders except hold until they are repaired.

#2330

@stuart stuart changed the title [WIP] stop RTR droids from dropping group and accepting orders Stop RTR droids from dropping group and accepting orders Nov 11, 2021
src/order.cpp Outdated Show resolved Hide resolved
@gantsevdenis
Copy link
Contributor

I think it's a good choice.
Units under commander also ignore all orders (even HOLD POSITION), so the only way to make them do something else, is to remove them from Commander's group, which is similar to here (once you fix your isRetreating).

@stuart stuart marked this pull request as ready for review November 12, 2021 00:42
src/order.cpp Outdated Show resolved Hide resolved
src/order.cpp Outdated Show resolved Hide resolved
src/order.cpp Outdated Show resolved Hide resolved
src/order.cpp Outdated Show resolved Hide resolved
@gantsevdenis
Copy link
Contributor

While it seemed to me a good fix, MP people aren't excited about this, because that prevent manual intervention in critical situations.
I suggest we wait for a more fine-grained solution

@KJeff01 KJeff01 removed the Blocker label Nov 26, 2021
@stuart
Copy link
Contributor Author

stuart commented Dec 4, 2021

I have been playing single player with this fix, and it works as intended with units rejoining after being repaired. I can see why you would not always want that behaviour especially in MP. By more fine-grained solution do you have anything in mind?

@gantsevdenis
Copy link
Contributor

Absolutely nothing :(
I have a solution, which would be to apply your fix for Campaign only, but given the fact that this bug was initially reported by MP community, that doesn't help much

@KJeff01 KJeff01 closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants