Use operator[] instead of .at() for asFeatureStats element access

Don't use `.at()` method, which performs additional bounds checking in cases where we know upfront that the element exists. Signed-off-by: Pavel Solodovnikov <[email protected]>
Warzone2100 · Jan 8, 2024 · e40b8ee · e40b8ee
1 parent 6b55a21
commit e40b8ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/feature.cpp b/src/feature.cpp
@@ -73,7 +73,7 @@ bool loadFeatureStats(WzConfig &ini)
 	{
 		ini.beginGroup(list[i]);
 		asFeatureStats.emplace_back(STAT_FEATURE + i);
-		FEATURE_STATS& p = asFeatureStats.at(i);
+		FEATURE_STATS& p = asFeatureStats[i];
 		p.name = ini.string(WzString::fromUtf8("name"));
 		p.id = list[i];
 		WzString subType = ini.value("type").toWzString();

diff --git a/src/hci.cpp b/src/hci.cpp
@@ -1272,7 +1272,7 @@ void intOpenDebugMenu(OBJECT_TYPE id)
 	case OBJ_FEATURE:
 		for (unsigned i = 0, end = std::min<unsigned>(asFeatureStats.size(), MAXFEATURES); i < end; ++i)
 		{
-			apsFeatureList[i] = &asFeatureStats.at(i);
+			apsFeatureList[i] = &asFeatureStats[i];
 		}
 		ppsStatsList = (BASE_STATS **)apsFeatureList;
 		intAddDebugStatsForm(ppsStatsList, std::min<unsigned>(asFeatureStats.size(), MAXFEATURES));