Implement review suggestions

Co-Authored-By: Pavel Solodovnikov <[email protected]>
Warzone2100 · Jan 14, 2024 · 2cb117d · 2cb117d
1 parent 26a5159
commit 2cb117d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/ivis_opengl/pielighting.h b/lib/ivis_opengl/pielighting.h
@@ -79,7 +79,7 @@ struct ILightingManager
 
 	virtual void ComputeFrameData(const LightingData& data, LightMap& lightmap, const glm::mat4& worldViewProjectionMatrix) = 0;
 
-	PointLightBuckets getPointLightBuckets() const
+	const PointLightBuckets& getPointLightBuckets() const
 	{
 		return currentPointLightBuckets;
 	}

diff --git a/src/terrain.h b/src/terrain.h
@@ -27,13 +27,14 @@
 #include "terrain_defs.h"
 
 struct ShadowCascadesInfo;
+struct LightMap;
 
 void loadTerrainTextures(MAP_TILESET mapTileset);
 
 bool initTerrain();
 void shutdownTerrain();
 
-void perFrameTerrainUpdates(const struct LightMap& lightData);
+void perFrameTerrainUpdates(const LightMap& lightData);
 void drawTerrainDepthOnly(const glm::mat4 &mvp);
 void drawTerrain(const glm::mat4 &mvp, const glm::mat4& viewMatrix, const Vector3f &cameraPos, const Vector3f &sunPos, const ShadowCascadesInfo& shadowMVPMatrix);
 void drawWater(const glm::mat4 &ModelViewProjection, const Vector3f &cameraPos, const Vector3f &sunPos);