Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Staff List Widget, [roster] shortcode, and related user meta forms #1506

Closed
wants to merge 4 commits into from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Aug 1, 2018

Changes

  • WIP

To Do

  • Because the meta boxes used by the Staff List Widget and the [roster] shortcode are also used for bylines, specifically the "job title" meta and the "show_email" meta, we're going to have to figure out how Largo and this plugin interact. Who is responsible for providing the form?
    • I think this might work best if Largo keeps the complete form, but unregisters the plugin's corresponding form functions. The metadata would remain the same across both the theme and the plugin.
  • Clean out tests for deprecated functions
  • Deprecate functions that are no longer used in Largo

Why

Because we're pulling this functionality out of Largo as part of #1505 and https://github.com/INN/staff

@benlk benlk self-assigned this Aug 1, 2018
@benlk benlk added priority: normal Must be completed before release of this version of plugin. status: in progress status: needs review labels Aug 1, 2018
@benlk benlk added this to the 0.6 - Performance & SEO milestone Aug 1, 2018
@benlk
Copy link
Collaborator Author

benlk commented Sep 10, 2018

This is not in the 0.6 milestone anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. status: in progress status: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant