-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new version of keycloak server with unit tests #74
Conversation
'fo=o', # invalid char | ||
'fo o', # space | ||
'f\'oo', # quote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These usernames can no longer be created in newer keycloak versions, which breaks test_user_put_invalid()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it break on client = await rest(username)
? I guess then it's useful to split this into two lists, the second of which goes to test_invalid_usernames()
and test_username_invalid()
.
@dsschult Could you take a look? Especially the changes in user_mgmt/handler.py. I am not sure if disappearance of 'groups' is significant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good.
'fo=o', # invalid char | ||
'fo o', # space | ||
'f\'oo', # quote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it break on client = await rest(username)
? I guess then it's useful to split this into two lists, the second of which goes to test_invalid_usernames()
and test_username_invalid()
.
So, the I'm not sure what that means if that's not working. I'd probably need to see more debugging. |
Looks like this is by design: keycloak/keycloak#22340 |
Ah, makes sense. In prod that's basically not a problem, but the |
No description provided.