Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.1 #41

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

v0.1.1 #41

wants to merge 53 commits into from

Conversation

dyxohjl666
Copy link
Collaborator

@dyxohjl666 dyxohjl666 commented Nov 29, 2023

Mainly fix dependency problems for installation, especially about inference function.

dyxohjl666 and others added 30 commits March 8, 2023 09:51
…torch-lightning version in requirements.txt

Signed-off-by: dyxohjl666 <[email protected]>
…fix of filenames of the results

Signed-off-by: dyxohjl666 <[email protected]>
Signed-off-by: dyxohjl666 <[email protected]>
Signed-off-by: dyxohjl666 <[email protected]>
Signed-off-by: dyxohjl666 <[email protected]>
Signed-off-by: dyxohjl666 <[email protected]>
Signed-off-by: dyxohjl666 <[email protected]>
…trolled

� Conflicts:
�	pyproject.toml
�	requirements.txt
�	src/SciAssist/pipelines/__init__.py
Signed-off-by: dyxohjl666 <[email protected]>
Signed-off-by: dyxohjl666 <[email protected]>
Update the default setting to controlled summarization

Signed-off-by: dyxohjl666 <[email protected]>
…trolled

� Conflicts:
�	pyproject.toml
�	src/SciAssist/pipelines/__init__.py
�	src/SciAssist/pipelines/summarization.py
�	src/SciAssist/utils/windows_pdf2text.py
Signed-off-by: dingy <[email protected]>
Signed-off-by: dingy <[email protected]>
@@ -855,7 +854,7 @@ def leng(prompt, length):
prompts = [ leng(prompt,length) for (prompt,length) in zip(prompts,lengths)]

inputs = [ prompt + ": " + raw_text for (prompt,raw_text) in zip(prompts, inputs) ]

print(inputs[0][:200])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear printing.

# Save prediction results
# with open(os.path.join(self.model.model_dir,"prediction.txt"),'w') as f:
# for batch in outputs:
# for res in batch["preds"]:
# f.write(res)
# f.write("\n")

for batch in outputs:
for id,res in zip(batch['id'],batch["preds"]):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter outputs is not supported in the new function

config.ckpt_path = os.path.join(hydra.utils.get_original_cwd(), config.ckpt_path)
elif config.ckpt_path == "None":
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow test on origin weights

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger is related to training procedure. FFT strategy requires lightning>=2.0. So have to change the logger class name to be compatible with newer version.

@@ -958,333 +959,6 @@ def get_dataloader(self, dataset, inputs_column="text", labels_column="summary")
return dataloader


# class DataUtilsForFiD():
# """
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused utils.

Copy link
Collaborator Author

@dyxohjl666 dyxohjl666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All resolved. Remain some comments to explain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants