Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs, changelog, add contributing.md #51

Merged
merged 3 commits into from
Nov 25, 2024
Merged

update docs, changelog, add contributing.md #51

merged 3 commits into from
Nov 25, 2024

Conversation

j-fu
Copy link
Member

@j-fu j-fu commented Nov 24, 2024

No description provided.

@j-fu
Copy link
Member Author

j-fu commented Nov 24, 2024

@jpthiele , @pjaap I think this can be released now as 1.9.

RGB type piracy has been removed, but pure tuples for rgb colors in the moment are not deprecated. E.g. Matplotlib happily lives with them, and I fear removing this possibility would break too much existing user code for almost no gain in functionality. I agree though to use the RGB(r,g,b) pattern in all examples and new code.

@j-fu
Copy link
Member Author

j-fu commented Nov 24, 2024

As for the format check, see fredrikekre/Runic.jl#107

@j-fu j-fu merged commit 0d84e0f into main Nov 25, 2024
2 of 9 checks passed
@j-fu j-fu deleted the jf/doc-update branch November 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant