Add ForkWatchJob #4
Conversation
CheckerApi/Jobs/ForkWatchJob.cs
Outdated
|
|
||
| class VirtualCheckpoint | ||
| { | ||
| public int Height; |
There was a problem hiding this comment.
Please use property, not field for DTOs. And convention follows to end with DTO in the name.
CheckerApi/Jobs/ForkWatchJob.cs
Outdated
| } | ||
| } | ||
|
|
||
| class VirtualCheckpoint |
CheckerApi/Jobs/ForkWatchJob.cs
Outdated
| public string Hash; | ||
| } | ||
|
|
||
| class WatchJobExecutor |
There was a problem hiding this comment.
Please move to separate .cs file , seems like Service, And convention follows to end with Service in the name.
CheckerApi/Jobs/ForkWatchJob.cs
Outdated
|
|
||
| public void Execute() | ||
| { | ||
| rpcConfig = JobCommon.GetRpcConfig(config); |
There was a problem hiding this comment.
Config can be injected into the method and gathered inside of the job.
CheckerApi/Jobs/ForkWatchJob.cs
Outdated
| if (shouldSend) | ||
| { | ||
| shouldBacktrace = true; | ||
| var url = ""; // TODO: upload to pastbin and get url |
CheckerApi/Jobs/ForkWatchJob.cs
Outdated
|
|
||
| if (tips == null || tips.Length == 0) | ||
| { | ||
| logger.LogWarning("ForkWatch: Got bad tip"); |
There was a problem hiding this comment.
Please add additional information, bad tip is not descriptive enough to determine a potential problem.
CheckerApi/Jobs/ForkWatchJob.cs
Outdated
| return; | ||
| } | ||
|
|
||
| // check virtual checkpoint rolled-back |
There was a problem hiding this comment.
Comments should explain why something is done, not how or what. Comment convention uses upper first letter.
CheckerApi/Jobs/ForkWatchJob.cs
Outdated
| var message = $"ForkWatch: Virtual checkpoint {lastCheckpoint.Hash} at height {lastCheckpoint.Height} replaced by {hash}"; | ||
| notificationManager.TriggerHook(message); | ||
| }); | ||
| // TODO: if foundReorg, move to "PREPARE" |
CheckerApi/Utils/JobCommon.cs
Outdated
| using Microsoft.Extensions.Configuration; | ||
| using System.Net; | ||
|
|
||
| public class JobCommon { |
There was a problem hiding this comment.
Please move as method inside of Job. Each job inherits that class.
This PR adds a job to watch chain fork