fix: stash and restore prediction when calling learn during learn_returns_prediction==false calls #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jackgerrits
commented
Aug 15, 2023
•
jackgerrits
commented
- Fixes Igl's usage of the prediction in learn
- Causes one less call to predict for cats which means the PRNG sequence changes and so do the predictions.
- Seems that expreplay used to be returning the final prediction that was coming out of GD in its learn call. This fixes that to be the initial predict.
…urns_prediction==false calls
ataymano
reviewed
Aug 22, 2023
| 30.00431,0.00625 | ||
| 0.51225615,0.40625 | ||
| 2.3816023,0.40625 | ||
| 25.271912,0.00625 |
There was a problem hiding this comment.
numbers here are crazily different - maybe this test can be reconsidered (in next PRs)
lalo
reviewed
Aug 23, 2023
|
|
||
| finished run | ||
| number of examples per pass = 200 | ||
| passes used = 8 | ||
| weighted example sum = 1600.000000 | ||
| weighted label sum = 728.000000 | ||
| average loss = 0.047746 | ||
| average loss = 0.455000 |
There was a problem hiding this comment.
Previous loss was cheating since it was using predictions that were coming out of learn.
ataymano
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.