test: [RLOS2023] add test for slate #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataymano
reviewed
Jul 31, 2023
ataymano
reviewed
Jul 31, 2023
ataymano
reviewed
Jul 31, 2023
ataymano
reviewed
Jul 31, 2023
| "params": {} | ||
| }, | ||
| "num_slot": 3, | ||
| "num_context": 2 |
There was a problem hiding this comment.
We are not using context here, so maybe we can start with 2 separate test scenarios:
- without context change (with reward function definition similar to what we have now)
- with context change (and with more explicit context dependency in reward function definition)
ataymano
reviewed
Jul 31, 2023
ataymano
reviewed
Jul 31, 2023
ataymano
reviewed
Aug 3, 2023
| reward_function, | ||
| logging_policy, | ||
| action_space, | ||
| num_context=1, |
There was a problem hiding this comment.
num_context is conflicting with context_name. Can we allow context_name to be a list and infer no_context from it?
ataymano
reviewed
Aug 3, 2023
| return reward[slot - 1][chosen_action - 1] | ||
|
|
||
|
|
||
| def reverse_reward_after_iteration(chosen_action, context, slot, **kwargs): |
ataymano
reviewed
Aug 3, 2023
| { | ||
| "name": "assert_loss", | ||
| "params": { | ||
| "expected_loss": 0.8, |
There was a problem hiding this comment.
expected loss should be slightly more than -2, but CI is still green
ataymano
added a commit
that referenced
this pull request
Oct 5, 2023
* intro notebook * test: [RLOS_2023][WIP] updated test for regression weight (#4600) * test: add test for regression weight * test: make test more reusable by using json to specify pytest * test: minor fix on naming * test: add and option to python json test * test: [RLOS_2023] test for contextual bandit (#4612) * test: add basic cb test and configuration * test: add shared context data generation * add test for cb_explore_adf * test: dynamically create pytest test case * test: give fixed reward function signature * test: [RLOS_2023] [WIP] Support + and * expression for grids (#4618) * test: add basic cb test and configuration * test: add shared context data generation * add test for cb_explore_adf * test: dynamically create pytest test case * test: give fixed reward function signature * test: support + and * expression for grids * fix empty expression bugs * test: [RLOS2023] [WIP] add more arguments for reg&cb tests (#4619) * test: add more arguments for reg&cb tests * test: fix minor bug in generate expression & add loss funcs to tests * test: [RLOS2023] [WIP] add classification test (#4623) * test: add more arguments for reg&cb tests * test: fix minor bug in generate expression & add loss funcs to tests * test: add test for classification * test: organize test framework structure (#4624) * test: [RLOS2023][WIP] add option for storing output and grid language redefinition (#4627) * test: redesign grid lang * test: add option for store output * test: change list to dict for config vars * test: [RLOS2023] add test for slate (#4629) * test: add test for slate * test: test cleanup and slate test update * test: minor cleanup and change assert_loss function to equal instead of lower * test: [RLOS2023] add test for cb with continous action (#4630) * test: add test for slate * test: test cleanup and slate test update * test: minor cleanup and change assert_loss function to equal instead of lower * test: add test for cb with continous action * modify blocker testcase * test: [RLOS2023] clean for e2e testing framework v2 (#4633) * test: clean for e2e test v2 * test:change seed to same value for all tests * test: add datagen driver (#4638) * python black * python black 2 * minor demo cleanup --------- Co-authored-by: Alexey Taymanov <[email protected]> Co-authored-by: Alexey Taymanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.