Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GCC when in release mode AND using ES module kind #65

Merged
merged 2 commits into from
May 22, 2024

Conversation

keynmol
Copy link

@keynmol keynmol commented May 22, 2024

No description provided.

@keynmol keynmol marked this pull request as ready for review May 22, 2024 11:38
Copy link

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@gzm0 gzm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustment in Scalajsld.scala LGTM. I have not looked at the tests.

Copy link

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@Gedochao Gedochao merged commit 6d10edd into VirtusLab:main May 22, 2024
7 checks passed
@keynmol keynmol deleted the fix-closure-usage-under-es branch May 22, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants