Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.2 & Laravel 10 update #374

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

Tachii
Copy link

@Tachii Tachii commented Oct 30, 2023

I have this draft PR to support php8^ & Laravel 10. #374
It's made from my personal fork, I invite anyone to collaborate: https://github.com/Tachii/NeoEloquent

To install and run it, add this to your composer.json:

Add at the top of the composer.json

"repositories": [
  {
    "type": "vcs",
    "url": "https://github.com/Tachii/NeoEloquent"
  }
 ]

Add this into require block

"require": {
  "vinelab/neoeloquent": "dev-php-8-laravel-10"
}

What was done:

  1. Replaced faker library that doesn't support php8^
  2. Updated needed dependencies to the same version as in Laravel 10
  3. Changed some of the methods to match parent classes/interfaces
  4. Added missing methods introduced in Laravel 10

@Tachii Tachii marked this pull request as ready for review October 30, 2023 17:28
@Tachii
Copy link
Author

Tachii commented Oct 30, 2023

@Mulkave Can you please take a look?

@Tachii Tachii changed the title PHP8^ & Laravel 10 update PHP8.2 & Laravel 10 update Oct 30, 2023
@Tachii Tachii marked this pull request as draft October 30, 2023 19:05
@Tachii Tachii mentioned this pull request Nov 1, 2023
@Tachii Tachii marked this pull request as ready for review November 14, 2023 04:39
@vsjoshtait
Copy link

@Tachii D'you need help with anything else? I'd be happy to.
@Mulkave Can we have an approval please?

Keen to use this.

@Tachii
Copy link
Author

Tachii commented Dec 23, 2023

@vsjoshtait I haven't checked it in a while, most likely will need to update tests and some other functionality, but it seems to work ok with basic methods and calls, haven't checked with more advanced ones tho

@babacarcissedia
Copy link

Looking forward for this one too

@matiasperrone
Copy link

I published a fork of this package as "global-innovation/neo4j-laravel-eloquent", it is tested on Laravel 11. Please try it if you can

https://github.com/global-innovation/neo4j-laravel-eloquent

composer require global-innovation/neo4j-laravel-eloquent

@babacarcissedia
Copy link

Nice work. We did this for up to Laravel 10 https://github.com/kirschbaum-development/laravel-couchbase

Looking forward to this one

@omitpavel
Copy link

@Tachii

PS C:\wamp\www\neo4j> php artisan neo4j:migrate

TypeError

Illuminate\Database\Query\Builder::__construct(): Argument #2 ($grammar) must be of type ?Illuminate\Database\Query\Grammars\Grammar, Vinelab\NeoEloquent\Query\Grammars\CypherGrammar given, called in C:\wamp\www\neo4j\vendor\laravel\framework\src\Illuminate\Database\Connection.php on line 345

at vendor\laravel\framework\src\Illuminate\Database\Query\Builder.php:241
237▕ * @param \Illuminate\Database\Query\Grammars\Grammar|null $grammar
238▕ * @param \Illuminate\Database\Query\Processors\Processor|null $processor
239▕ * @return void
240▕ */
➜ 241▕ public function __construct(ConnectionInterface $connection,
242▕ Grammar $grammar = null,
243▕ Processor $processor = null)
244▕ {
245▕ $this->connection = $connection;

1 vendor\laravel\framework\src\Illuminate\Database\Connection.php:345
Illuminate\Database\Query\Builder::__construct(Object(Vinelab\NeoEloquent\ConnectionAdapter), Object(Vinelab\NeoEloquent\Query\Grammars\CypherGrammar))

2 vendor\laravel\framework\src\Illuminate\Database\Connection.php:335
Illuminate\Database\Connection::query()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants