Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LightGlue for DeDoDe (v2) #100

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Dawars
Copy link
Contributor

@Dawars Dawars commented Nov 23, 2024

Proposed changes:

  • Changed DeDoDe and LightGlue to kornia implementation
  • Changed DeDoDe to G variant
  • Added DeDoDe v2
  • Added LightGlue support for DeDoDe
  • Removed (now) unneeded submodule for DeDoDe (LightGlue is still used in ALIKED Added ALIKED+LightGlue #99)

Let me know if I should change back DeDoDe to the smaller variant

@Vincentqyw
Copy link
Owner

Thank you for your PR. I think using the implementation in kornia is a great approach, and I agree with your modification.

Additionally, I'm contemplating a more reasonable way to manage the numerous model files in the repository. Currently, I'm storing all model files in Hugging Face's model hub. The issue at hand is that the same model gets downloaded multiple times. For instance, both roma and dedodev2 use dinov2_vitl14_pretrain.pth. The former uses hf_hub_download for downloading, while the latter uses the method within kornia, possibly through torch hub, resulting in dinov2_vitl14_pretrain.pth being downloaded twice. However, I would prefer to avoid this situation. If you have a good solution, feel free to submit a PR. Thanks again.

@Dawars
Copy link
Contributor Author

Dawars commented Nov 23, 2024

I fixed the formatting.
I'll look into the duplicate weights when I have time again.

@Vincentqyw
Copy link
Owner

Conflicting files exist following the merge #99. Kindly address these conflicts along with certain CI issues.

# Conflicts:
#	hloc/match_features.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants