Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has a lot of stuff, so I'm going over it in this message.
The current version of
Minimap.GetDotsBitmap()
has several flaws:My change tries to address all of this.
First, the shadow logic was separated into it's own function
TRSMinimap.FindDotShadows()
and it's the core of all of this.This method is large and complex but once you understand how it works it should be fairly easy to understand.
TRSMinimap.FindDotShadows()
is slower than the current live version but only by 1.5/2 times which is pretty good if you have in mind it checks almost 20 times more pixels.The way it works is roughly like this:
There are still some scenarios where this new method breaks but they are very few and way less than the previous method