Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed not yet existing operator path #1016

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Jul 4, 2024

  • add olm operator path if it's not yet present
  • revert tagging for config-reloader
  • use single tag for generated tag for images with ability to override it
  • fixed links in docs to kubernetes objects
  • use pull request action in all workflows instead of gh tool

Makefile Outdated
-f Dockerfile.cross .
- $(CONTAINER_TOOL) buildx rm vm-builder
rm Dockerfile.cross

publish:
REPO=operator ROOT=./cmd $(MAKE) docker-buildx
REPO=config-reloader ROOT=./cmd/config-reloader $(MAKE) docker-buildx
#ROOT=./cmd $(MAKE) docker-buildx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like TYPO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed it

Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit b6ed072 into master Jul 4, 2024
2 checks passed
@f41gh7 f41gh7 deleted the fixed-not-existing-path branch July 4, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants