Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standard doclet flags, so that this is usable under Gradle #84

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

niloc132
Copy link
Member

Fixes #83

@niloc132 niloc132 requested a review from vegegoku October 21, 2023 01:37
@vegegoku
Copy link
Member

The build fails due to some transitive dependency changes in the dtslint module, it seems the last working version with our repository is 0.0.182 while latest is 0.0.184

We can avoid the error by fixing the version in the pom.xml here

should become

<arguments>install --prefix ${project.build.directory}/test-classes --save-dev @definitelytyped/[email protected] typescript</arguments>

@niloc132 niloc132 merged commit 13a1359 into Vertispan:main Oct 24, 2023
2 checks passed
vegegoku pushed a commit that referenced this pull request Oct 29, 2023
vegegoku pushed a commit that referenced this pull request Oct 29, 2023
vegegoku pushed a commit that referenced this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle always passes -d to doclets, consider supporting this instead of -tsoutput
2 participants