-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing page #26
base: release/1.0
Are you sure you want to change the base?
Landing page #26
Conversation
Would be nice if you could attach a screenshot as well.
|
src/ChatApp.jsx
Outdated
</div> | ||
<p className="mb-5 text-center text-gray-400 mt-2 text-sm">VERSEwise Ai can make mistakes. Check important info.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract text to a resource file, as we might include localization in the future, and it is also good for reusability(incase).
- Extract string values to a resource
src/components/LandingPage.jsx
Outdated
Welcome to our Chat Bot! | ||
<div className={` flex flex-col text-center l:text-start max-w-[70%] mx-auto mt-[20px] lg:w-[700px] lg:mr-10 gap-[20px] justify-start`}> | ||
<div className={`mx-auto text-[32px] leading-[44px] font-semibold w-[90%] l:w-full l:font-normal l:text-[64px] l:leading-[87px] mt-26 lg:mt-80`}> | ||
Introducing VERSEwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Extract string values to a resource file
src/components/LandingPage.jsx
Outdated
</div> | ||
<div className={`text-[22px] leading-[30px] font-bold text-[#EF4E25] l:leading-[51px] l:text-[37px] l:font-normal`}>Wisdom at your command.</div> | ||
|
||
<div className='font-semibold text-[14px] leading-[19px] text-[#FFFFFF78] l:text-[24px] l:leading-[32px] l:font-normal'> | ||
The fear of the LORD is the beginning of wisdom, and knowledge of | ||
the Holy One is understanding. | ||
Explore Personalized Spiritual Guidance with Versewise – Your AI-Powered Companion for Wisdom, Insight, and Clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Extract string values to a resource file
Would really be nice if you follow commit message formats
|
}; | ||
|
||
// Helper functions to abstract the logic of getting path data, stroke color, and blur paths. | ||
function getPathD(index) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I highly recommend extracting helper functions into separate files
- Extract helpers into files
maybe if the "patterned background" is extended to the "your spritual questions" part too. and the CTA button have a the "#EF4225" background color with white |
src/ChatApp.jsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing unused commented code
src/components/Home.jsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
src/components/ui/Compare.jsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest moving inline styles to a separate CSS or SCSS file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@misudesu we can't merge this with fake testimonials. Lets discuss this in discord and come up with a solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yaya, that is right , i put how it look , when we write our testimonial or collate sample from neighbor it will work.
No description provided.