Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes test pipeline issue tpp #539

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

luispresuelVenafi
Copy link
Contributor

@luispresuelVenafi luispresuelVenafi commented Nov 21, 2024

Since when we introduced the workToDoTimeout attribute to be set for TPP request in VCert, we have had some sporadic issues in tests with the following error:

[2024-11-21T09:44:32.149Z]     connector_test.go:2304: Unexpected status code on TPP Certificate Request.
[2024-11-21T09:44:32.149Z]          Status:
[2024-11-21T09:44:32.149Z]          202 Accepted. 
[2024-11-21T09:44:32.149Z]          Body:
[2024-11-21T09:44:32.149Z]         {
    "CertificateDN": "\\VED\\Policy\\<redacted>\\redacted.example.com",
    "Devices": [
        {
            "Applications": [
                {
                    "DN": "\\VED\\Policy\\<redacted>\\instance\\workload-17redacted55"
                }
            ],
            "DN": "\\VED\\Policy\\redacted\\instance"
        }
    ],
    "Error": "Certificate processing took longer than WorkToDoTimeout. Call certificates\/retrieve to get the certificate data",
    "Guid": "{c2XXXXXX-c7XX-4cXX-XXXX-1XXXXXXXXXX7}"
}

These tests had a very short timeout of 10 seconds set, which, in case TPP took longer that, our pipeline would fail.

This PR address that issue as well as some minor fixes

…d and rather just produces sporadic errors in pipeline if TPP is not fast enough
… request set timeout in some tests since that now VCert it uses it to set workToDoTimeout, it will give us errors when the tiemout is very small. Now we use TPP's default value for it
@luispresuelVenafi luispresuelVenafi merged commit 594fe6a into master Nov 26, 2024
3 checks passed
@luispresuelVenafi luispresuelVenafi deleted the fixes-test-pipeline-issue-tpp branch November 26, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants