Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/incremental-models #316

Closed
wants to merge 10 commits into from
Closed

feat/incremental-models #316

wants to merge 10 commits into from

Conversation

chienazazaz
Copy link

@chienazazaz chienazazaz commented Mar 28, 2024

Description & motivation

Convert some models materialization from table/view to incremental to reduce the amount of data processed at each update

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have run dbt test and python -m pytest . to validate existing tests

@adamribaudo-velir
Copy link
Collaborator

It looks like you accidentally committed your project settings in https://github.com/chienazazaz/dbt-ga4/blob/main/dbt_project.yml

Also, the goal of the PR seems to be to make the sessions models incremental, which is what the "_daily" models are for: https://github.com/chienazazaz/dbt-ga4/blob/main/models/marts/core/dim_ga4__sessions_daily.sql

GA4 sessions by default can last >1 day which is why the main sessions tables are not partitioned on day, but the _daily models are.

I'm going to close the PR given that its purpose is unclear and it's only barely documented. Please open an issue to discuss what you'd like the contribute before opening another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants