Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uniqueness test for fct_ga4__pages #305

Merged

Conversation

yamotech
Copy link
Contributor

@yamotech yamotech commented Mar 5, 2024

Description & motivation

Fix uniqueness test for fct_ga4__pages.

Multiple records can have the same event_date_dt and page_location.
Adding stream_id as a condition makes them unique.

Data stream: Lives within a property, and is the source of data from an app or website. The best practice is to use a maximum of 3 data streams per property: 1 single web data stream to measure the web user journey and 1 app data stream each for iOS and Android.

[GA4] Google Analytics account structure - Analytics Help

Checklist

  • I have verified that these changes work locally
  • [na] I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have run dbt test and python -m pytest . to validate existing tests

yamotech added 2 commits March 5, 2024 11:20
Multiple records can have the same event_date_dt and page_location.
Adding stream_id as a condition makes them unique.

> Data stream: Lives within a property, and is the source of data from an app or website. The best practice is to use a maximum of 3 data streams per property: 1 single web data stream to measure the web user journey and 1 app data stream each for iOS and Android.
>
> [[GA4] Google Analytics account structure - Analytics Help](https://support.google.com/analytics/answer/9679158?hl=en)
Updated description of fct_ga4__pages.
Copy link
Collaborator

@dgitis dgitis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you.

@adamribaudo-velir adamribaudo-velir merged commit 814dba7 into Velir:main Mar 13, 2024
1 check passed
@yamotech yamotech deleted the fix-uniqueness-test-for-fct_ga4__pages branch March 24, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants