Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default channel grouping label to Direct #301

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

adamribaudo-velir
Copy link
Collaborator

Description & motivation

Fixes #300

The default session grouping for the last-non-direct model was mistaken set to (none) instead of Direct when the source was direct. This was likely a copy/paste error.

Checklist

  • I have verified that these changes work locally
  • [na] I have updated the README.md (if applicable)
  • [na] I have added tests & descriptions to my models (and macros if applicable)
  • I have run dbt test and python -m pytest . to validate existing tests

@adamribaudo-velir adamribaudo-velir merged commit f9558ac into main Feb 29, 2024
1 check passed
@adamribaudo-velir adamribaudo-velir deleted the fix-direct-session-last-non-direct branch February 29, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Set "Direct" instead "(none)" for last_non_direct_default_channel_grouping
2 participants