fix fct_ga4__pages model and add tests to catch similar issues #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
The addition of
page_engagement_key
which is built from thepage_referrer
where page_view events are concerned was causing multiple rows with the samepage_location
andevent_date_dt
in the first CTE.This PR adds a second aggregation in the second CTE to eliminate this redundancy and adds tests to the model to catch these issues in the future.
The
fct_ga4__pages
model will need a full refresh when upgrading to a version containing these changes as the new tests will trigger an error.Resolves #274
Checklist
dbt test
andpython -m pytest .
to validate existing tests