Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Item and Ecommerce field selection #283

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Conversation

dgitis
Copy link
Collaborator

@dgitis dgitis commented Nov 10, 2023

Description & motivation

In order to prevent Google changes to the items and ecommerce records breaking the package, this PR hard-codes the fields output by the base_select macro which will prevent changes from breaking and allow users to override the macro and incorporate changes without waiting on a package update.

Resolves #281

Checklist

  • [y ] I have verified that these changes work locally
  • [y ] I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • [y ] I have run dbt test and python -m pytest . to validate existing tests

@dgitis
Copy link
Collaborator Author

dgitis commented Nov 10, 2023

The ReadMe changes may not be necessary. I thought I'd found my test project which has data going back a long had a couple of fields missing, but it was an error on my part compounded by my needing to run a full refresh on my test environment which stopped me from catching the missing fields.

and will make a new 5.1 release
@adamribaudo-velir adamribaudo-velir merged commit 634a896 into main Nov 12, 2023
@adamribaudo-velir adamribaudo-velir deleted the item-fields branch November 12, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The new items format for custom parameters causes base models to error
2 participants