Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align default channel groupings with GA4 docs #282

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

erikverheij
Copy link
Contributor

Description & motivation

Align default channel groupings with GA4 docs. The following things have been changed:

  • Order of statements aligned with order in GA4 docs.
  • Refactored test: Included more test cases and combined input with the expected channel for easier readability.
  • Added campaign param to default_channel_grouping() method as it was needed for some mappings.
  • Included GA4 descriptions to make it easier to maintain.
  • Updated ga4_source_categories.csv based on PDF download from https://support.google.com/analytics/answer/9756891?hl=en#list
  • Removed the reference to https://github.com/llooker/ga_four_block_dev as I don't think their implementation is used anymore.

Also see issue #273.

Checklist

  • [ ✅] I have verified that these changes work locally
  • [ not applicable] I have updated the README.md (if applicable)
  • [✅] I have added tests & descriptions to my models (and macros if applicable)
  • [✅ ] I have run dbt test and python -m pytest . to validate existing tests

Copy link
Collaborator

@adamribaudo-velir adamribaudo-velir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the thorough unit test. Just had to replace curly quotes as it was causing a text parsing issue for me.

@adamribaudo-velir adamribaudo-velir merged commit 9dfdbd4 into Velir:main Nov 4, 2023
@erikverheij
Copy link
Contributor Author

Great! Thanks for reviewing & merging it so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants