Updated documentation comments #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Thanks for the PR. Can you remove the generated html files? I will handle that on end! |
|
Can do! |
|
Hey there are still changes in docs folder. |
|
My mistake. I thought you only wanted the HTML files removed |
|
Hey, I think you messed up the commit, you need to roll back the commit and then just add the header changes to the commit. Now it seems you deleted the complete doc folder in your repo. |
|
Ah my mistake. Will fix. |
- Moved function description comments to header files - Corrected tcp_network_manager function description
JerelJr
force-pushed
the
docs/update-comments
branch
from
40bf0e0
to
8d052e4
Compare
VedantParanjape
requested changes
Nov 19, 2024
| char* generate_log_message_timestamp(uint log_level, uint32_t timestamp, char* log_message); | ||
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
||
| #endif |
There was a problem hiding this comment.
can you add back the new line?
| bool is_connected(void* handle_t); | ||
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
||
| #endif | ||
|
|
| return c_log_string; | ||
| } |
|
Just for clarity, you want me to add a new line to the end of each of those files, correct? |
yeah, correct, undo the changes basically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #3.
tcp_network_managerdescription; return type is bool not void