Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DAppBrowser and Navbar #20

Merged
merged 8 commits into from
Oct 5, 2024
Merged

Added DAppBrowser and Navbar #20

merged 8 commits into from
Oct 5, 2024

Conversation

ayush-848
Copy link
Contributor

@ayush-848 ayush-848 commented Oct 2, 2024 •
edited
Loading

Closes #15
image

@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:49pm

github-actions[bot]
github-actions bot reviewed Oct 2, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@ayush-848
Copy link
Contributor Author

@VedantAnand17 please check
I created a home component to and had to rearrange the props

@VedantAnand17
Copy link
Owner

Good work man 👏
What I meant to say by NavBar was kindly edit the option on top to navigate between home page and dApp browser, kindly rectify it and also check the responsiveness :)

@ayush-848
Copy link
Contributor Author

Good work man 👏 What I meant to say by NavBar was kindly edit the option on top to navigate between home page and dApp browser, kindly rectify it and also check the responsiveness :)

Should i remove the home about options from navbar

@ayush-848
Copy link
Contributor Author

image
@VedantAnand17 see this

@VedantAnand17
Copy link
Owner

Kindly comment out the service and contact pages :)

@ayush-848
Copy link
Contributor Author

ayush-848 commented Oct 2, 2024 •
edited
Loading

Kindly comment out the service and contact pages :)

image
done @VedantAnand17

@VedantAnand17
Copy link
Owner

NavBar is unresponsive and has no home button 😅

@ayush-848
Copy link
Contributor Author

NavBar is unresponsive and has no home button 😅

@VedantAnand17 Oh i forgot about the responsive ness
and the logo is the home button itself

@VedantAnand17
Copy link
Owner

UX of home as logo is not good, kindly make a simple anchor for it :)
(You can use the commented out Home anchor )

@ayush-848
Copy link
Contributor Author

ayush-848 commented Oct 2, 2024 •
edited
Loading

UX of home as logo is not good, kindly make a simple anchor for it :) (You can use the commented out Home anchor )

Should I remove the logo
or Add a Home button or home link beside the DAppBrowser button @VedantAnand17

@ayush-848
Copy link
Contributor Author

Now check

@ayush-848
Copy link
Contributor Author

@VedantAnand17 please merge it if it is ok

@VedantAnand17
Copy link
Owner

Testing

@VedantAnand17 VedantAnand17 merged commit f5cf015 into VedantAnand17:main Oct 5, 2024
2 checks passed
@ayush-848
Copy link
Contributor Author

ayush-848 commented Oct 8, 2024 •
edited
Loading

@VedantAnand17 add the labels in the PRs too, else they don't get counted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
wob
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrating a DApp browser inside the website
2 participants
@ayush-848 @VedantAnand17