-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Localization (Stringtable.xml) #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, very good job here!
I just saw some little missing localization:
Also, there are some conflicts with master_daily do you need help to resolve them ?
When those conflicts will be resolved, you will notice some new file (due to recent PR (#398 #386)). Those files will need also a localization (in futur, to avoid this prefer to work on master_daily because master_daily add a lot of change in H&M). We could merge this and after take care of those new files in a different PR ? |
Sorry forget about these files.
Yeah, After the merge, I will upgrade those files as fast as possible. And yes I use a new PR for these. |
PS: The last 4 commits are just to resolve the conflicts. 😄 |
Not for github 😄 |
You need to push vdauphin/master_daily into 1kuemmel1/add-localization. Then git will tell you there are conflicts. You need now to deal with and resolve then one by one. |
Sorryyy vdauphin/master_daily into 1kuemmel1/add-localization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time I switch my Arma to German x) . And good job, works very well!
Just a little question : is it possible to have in mission parameter a little offset of the text like it was done here ?
Found a solution for the offset problem. Should be like before.
🤣 😄 👍 Just an additional note: to get the full language support, the dedicated server must run in the user's language ➡️ English server + German client = mixed language |
[btc_gear_object, 0, ["ACE_MainActions"], _action] call ace_interact_menu_fnc_addActionToObject; | ||
|
||
//Arsenal | ||
_action = ["arsenal_open", (localize "STR_BTC_HAM_ACTION_ARSENAL_OPEN"), "\A3\ui_f\data\igui\cfg\simpleTasks\letters\A_ca.paa", {['Open',true] spawn BIS_fnc_arsenal;}, {true}, {}, [], [0.4,0,0.4], 5] call ace_interact_menu_fnc_createAction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this interaction ? See this #166
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe obsolete? Tested local and on a dedicated server, no crash or error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but this issue come randomly after some days on a dedicate server. Also, this interaction is not use by player beacause when you are more than 2 or 3 people around the box this action is no more available due to other player. The advantage of the scroll menu is even 10 players around the box, Arsenal is still available.
So I decided to remove it because it create random crash and not use by player.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will remove this.
btc_gear_object addAction ["<t color='#ff1111'>Arsenal</t>", "['Open',true] spawn BIS_fnc_arsenal;"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localize this no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply forget this, sorry.
This pull request added:
Final test: