Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Set day time and change weather #1475

Merged
merged 10 commits into from
Jan 18, 2023
Merged

Add: Set day time and change weather #1475

merged 10 commits into from
Jan 18, 2023

Conversation

SOF-Ice
Copy link

@SOF-Ice SOF-Ice commented Jan 14, 2023 •
edited by Vdauphin
Loading

  • Add: Possibility to create ACE interaction to change time and weather /!\ only for officers /!\ (@SOF-Ice, @TomDraal).

When merged this pull request will:

  • Add Ace interaction on btc_gear_object
  • Possibility to change time (day or night) and weather in game without using Zeus modules
  • Add new containers and keys in stringtable for those script with french traduction
  • Discussion: Multilingual support #400

Final test:

  • local
  • server

Screenshot

20230114030039_1

@Vdauphin Vdauphin added this to the 1.23 milestone Jan 14, 2023
@SOF-Ice SOF-Ice changed the title Set day time and change weather ADD: Set day time and change weather Jan 14, 2023
@SOF-Ice SOF-Ice changed the title ADD: Set day time and change weather Add: Set day time and change weather Jan 14, 2023
@Vdauphin
Copy link
Owner

Hello,
May be I wrongly test the weather feature but it doesn't do anything for me
When I run it and set the day as cloudy with ACE weather, the weather interaction doesn't change it to sunny

Can you tell me how you tested it?
Cheers

Vdauphin
Vdauphin requested changes Jan 15, 2023
View reviewed changes
Copy link
Owner

@Vdauphin Vdauphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the weather it might be something from ACE.
Some last stuff need to be change before approval

=BTC=co@30_Hearts_and_Minds.Altis/core/def/param.hpp Outdated Show resolved Hide resolved
=BTC=co@30_Hearts_and_Minds.Altis/core/def/param.hpp Outdated Show resolved Hide resolved
=BTC=co@30_Hearts_and_Minds.Altis/core/fnc/int/add_actions.sqf Outdated Show resolved Hide resolved
=BTC=co@30_Hearts_and_Minds.Altis/core/fnc/int/add_actions.sqf Outdated Show resolved Hide resolved
Vdauphin
Vdauphin approved these changes Jan 17, 2023
View reviewed changes
Copy link
Owner

@Vdauphin Vdauphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution guys!

@Vdauphin Vdauphin merged commit 5e18f15 into Vdauphin:master_daily Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vdauphin Vdauphin Vdauphin approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.
2 participants
@SOF-Ice @Vdauphin