Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[#23] detect failure and report to user #33

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

jardon
Copy link
Member

@jardon jardon commented Dec 5, 2024

  • repurpose SideloaderInstallDone to handle failure
  • remove dedicated fail ui
    image

closes #23

@jardon
Copy link
Member Author

jardon commented Dec 6, 2024

i dont think this can be done until this gets fixed. since vso always reports a success, the vte terminal status is inaccurate.

@jardon
Copy link
Member Author

jardon commented Dec 9, 2024

This may be sufficient as-is, but i need to test it more. If the exit code is reported correctly, it should work as expected.

@jardon
Copy link
Member Author

jardon commented Dec 9, 2024

@mirkobrombin do you know if the VTE terminal checks in the users $PATH for the subprocess? i have an upstream change from vso installed locally in ~/.local, but it appears its returning a 0 status code.

@mirkobrombin
Copy link
Member

VTE itself does not, it expect PATH to be set, which I think is the case. What happen if you hard code a echo $PATH and run VTE?

- repurpose sideloaderinstalldone to display error
- remove fail UI
@jardon jardon force-pushed the fix/handle-failure branch from ea9d53e to 1bd6831 Compare December 10, 2024 19:53
@jardon
Copy link
Member Author

jardon commented Dec 10, 2024

this does behave correctly with the upstream fix. ive rebased and it should be ready to merge, but it wont display an error was detected until that vso change is included in a new release.

@jardon jardon marked this pull request as ready for review December 10, 2024 19:55
@jardon jardon requested a review from mirkobrombin December 10, 2024 19:55
Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jardon jardon merged commit fe4d53e into main Dec 10, 2024
2 checks passed
@kbdharun kbdharun deleted the fix/handle-failure branch December 11, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the utility shows install succeeded even when it fails installing the package
2 participants