feat: view logs after post script run #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert retry button to view logs - add next button to post script view - increase margin for terminal box
jardon
force-pushed
the
feat/view-post-script-output
branch
from
2c0dc34 to
48a45a3
Compare
mirkobrombin
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reworked the retry button to go back to view logs. its really annoying when theres an issue and it auto moves to done without letting the user see whats up. the logging doesnt even work at the moment so its a bear to try to figure out whats wrong with the post scripts. i plan to address the logging portion of that in another PR. Also, the retry button doesnt rerun the script so its more or less the same functionality.