Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:[#339] network check without network interface #342

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix:[#339] network check without network interface #342

merged 1 commit into from
Oct 2, 2024

Conversation

jardon
Copy link
Member

@jardon jardon commented Oct 1, 2024

  • Split out network check from conn_check into static function
  • Check for network by request success instead of network interfaces

Closes #339

@jardon
fix:[Vanilla-OS#339] network check without network interface
0c3b03c 
- Split out network check from conn_check into utility function
- Check for network by request success instead of network interfaces
@jardon jardon force-pushed the fix/network-check-cont branch from 550bdef to 0c3b03c Compare October 2, 2024 10:55
@jardon jardon requested a review from mirkobrombin October 2, 2024 10:57
@jardon jardon marked this pull request as ready for review October 2, 2024 10:57
@jardon jardon merged commit 1718547 into Vanilla-OS:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkobrombin mirkobrombin mirkobrombin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network check fails in container
2 participants
@jardon @mirkobrombin