Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: toggle not selecting keyboard #340

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix: toggle not selecting keyboard #340

merged 1 commit into from
Oct 3, 2024

Conversation

jardon
Copy link
Member

@jardon jardon commented Oct 1, 2024 •
edited
Loading

  • Add callback function for radio button and row to use for selection

closes #336

@jardon jardon changed the title Add toggle and breakpoint Fix: toggle not selecting keyboard Oct 1, 2024
@jardon jardon force-pushed the fix/keyboard-select branch 2 times, most recently from 5ced1c7 to accd682 Compare October 2, 2024 16:21
@jardon
fix: radio button unlock next button
aacf0ba 
- pass callback for radio button and row to call
@jardon jardon force-pushed the fix/keyboard-select branch from accd682 to aacf0ba Compare October 3, 2024 00:08
@jardon jardon marked this pull request as ready for review October 3, 2024 00:17
@jardon
Copy link
Member Author

jardon commented Oct 3, 2024

This fixes the behavior in the linked issue. I'm not sure if the name mangling is helpful here, but I'm open to opinions.

@jardon jardon merged commit 3622b75 into Vanilla-OS:main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkobrombin mirkobrombin mirkobrombin approved these changes

@Muqtxdir Muqtxdir Awaiting requested review from Muqtxdir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keyboard radio button not selecting
2 participants
@jardon @mirkobrombin