Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[close #169]: pre-run vso shell at boot if already initialized #170

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

mirkobrombin
Copy link
Member

@mirkobrombin mirkobrombin commented Jul 20, 2024

Since user sysd units cannot depend on system targets, I made a custom script that uses nmcli to check for the connectivity, then used it as a condition in ExecStartPre.

Tested on a VM:

  • installed the unit
  • restarted the VM
  • I noticed that Vso didn't show the distrobox initialization process but the prompt directly

@mirkobrombin mirkobrombin requested a review from taukakao July 20, 2024 20:51
@mirkobrombin

This comment was marked as outdated.

fix: wrong path

feat: add custom script to check for connectivity

feat: improve network connectivity check
Copy link
Member

@taukakao taukakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taukakao taukakao merged commit bcf3d72 into main Jul 21, 2024
2 checks passed
@taukakao taukakao deleted the feat/169 branch July 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants