Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: a service for vso tasks rotation #140

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat: a service for vso tasks rotation #140

merged 1 commit into from
Jun 26, 2024

Conversation

nellfs
Copy link
Contributor

@nellfs nellfs commented Jun 22, 2024 •
edited
Loading

closes #136

This removes the need for creating a autostart file directly into the home directory with vanilla system operator

https://github.com/Vanilla-OS/vanilla-system-operator/blob/05757fb763d43645db2c6ce8b4796f831f928318/core/tasks.go#L271-L303

@nellfs nellfs changed the title feat: Service for vso tasks rotate feat: a service for vso tasks rotation Jun 22, 2024
This was referenced Jun 23, 2024
Closed
Merged
taukakao
taukakao requested changes Jun 23, 2024
View reviewed changes
Copy link
Member

@taukakao taukakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be removed:
https://github.com/Vanilla-OS/desktop-image/blob/87b2dbf239972d03452cc5f10fcc9f8d4f422d66/modules/.171.vso-tasks-rotation-autostart.yml.swp

It's a state file that got created by some text editor.

@nellfs
Copy link
Contributor Author

nellfs commented Jun 23, 2024

This file needs to be removed: https://github.com/Vanilla-OS/desktop-image/blob/87b2dbf239972d03452cc5f10fcc9f8d4f422d66/modules/.171.vso-tasks-rotation-autostart.yml.swp

It's a state file that got created by some text editor.

Hadn't noticed, I think my editor failed to delete this for some weird reason, now it should be okay

taukakao
taukakao approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@taukakao taukakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taukakao
Copy link
Member

Please squash the commits into one before you merge

mirkobrombin
mirkobrombin approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mirkobrombin mirkobrombin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to squash all commits into a single one feat[close #136]: Add service for vso tasks rotation

@nellfs
Copy link
Contributor Author

nellfs commented Jun 25, 2024

LGTM! Remember to squash all commits into a single one feat[close #136]: Add service for vso tasks rotation

Commits have been squashed!

taukakao
taukakao approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@taukakao taukakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taukakao taukakao merged commit fba7eb3 into Vanilla-OS:main Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taukakao taukakao taukakao approved these changes

@mirkobrombin mirkobrombin mirkobrombin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add service for vso tasks rotation
3 participants
@nellfs @taukakao @mirkobrombin