Sofia's Edits #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install additional packages - install.packages("knitr"), install.packages("devtools"), BiocManager::install("limma"), BiocManager::install("GEOquery"), BiocManager::install("ComplexHeatmap"),
The rest of the code runs.
Based on this code, it is hard to understand what is the result and what the original question was. I also do not clearly understand the logic behind arranging the code in this order.
PAMatusiak
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Sofia, I see that you found a vital error in Tim's code. I found the same error, and to fix it, I used the same code you did. Go team!
My only recommendation is that you insert your BiocManager:: lines of code (lines 22-23) at the beginning, in the first chunk, before load.all (line 19). I get why you put it where you did, but if load.all wont work until you use BiocManager, you might as well put BiocManager first, right?
|
I agree with Paige on this. Everything else looks good |
|
Good catch on the package installations! I agree that the original code could have been annotated a bit more clearly (especially in the last chunk). Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install additional packages - install.packages("knitr"), install.packages("devtools"), BiocManager::install("limma"), BiocManager::install("GEOquery"), BiocManager::install("ComplexHeatmap"),
The rest of the code runs.
Based on this code, it is hard to understand what is the result and what the original question was. I also do not clearly understand the logic behind arranging the code in this order.